Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Container Images] Changes to integrate us with heighliner #519

Closed
wants to merge 29 commits into from
Closed

[Container Images] Changes to integrate us with heighliner #519

wants to merge 29 commits into from

Conversation

okdas
Copy link
Member

@okdas okdas commented May 6, 2024

Summary

Allows us to integrate with heighliner container build processes to enable production-grade container images and kubernetes operator integration

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

Documentation changes (only if making doc changes)

  • make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • See quickstart guide for instructions

PR Testing (only if making code changes)

  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
    • THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
    • Optionally run make trigger_ci if you want to re-trigger tests without any code changes
    • If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@okdas okdas added infra Infra or tooling related improvements, additions or fixes tooling Tooling - CLI, scripts, helpers, off-chain, etc... labels May 6, 2024
@okdas okdas added this to the Shannon Private TestNet milestone May 6, 2024
@okdas okdas self-assigned this May 6, 2024
okdas
okdas commented May 8, 2024
View reviewed changes
localnet/kubernetes/anvil.yaml
@@ -16,7 +16,8 @@ spec:
# TODO: Add resource limits
containers:
- name: anvil
image: ghcr.io/foundry-rs/foundry:latest
# TODO: going with a static tag instead of `latest` or `nightly` as latest is currently broken for darwin/arm64.
image: ghcr.io/foundry-rs/foundry:nightly-3fa02706ca732c994715ba42d923605692062375
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Olshansk try this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this works for me. Ty

@okdas
Copy link
Member Author

okdas commented May 22, 2024

We'll create a community ticket to integrate with cosmos k8s operator.

@okdas okdas closed this May 22, 2024
@Olshansk Olshansk mentioned this pull request May 22, 2024
Closed
36 tasks
@Olshansk
Copy link
Member

Olshansk commented May 22, 2024 •
edited
Loading

We'll create a community ticket to integrate with cosmos k8s operator.

I added it to the list in #437

This was referenced Jun 4, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Olshansk Olshansk Olshansk left review comments

Assignees

@okdas okdas

Labels
infra Infra or tooling related improvements, additions or fixes tooling Tooling - CLI, scripts, helpers, off-chain, etc...
Projects
Shannon
Status: ✅ Done
Milestone
Shannon MainNet
Development

Successfully merging this pull request may close these issues.
2 participants
@okdas @Olshansk